josh/j3ml
1
0
Fork 1
Code Issues 12 Pull Requests Actions Packages Projects Releases 41 Wiki Activity

Add AABB v AABB & Triangle v Triangle intersection, and fix dot product #27

Merged
josh merged 3 commits from Miuna/j3ml-fork:main into main 2024-05-08 13:35:05 -04:00
Conversation 4 Commits 3 Files Changed 12 +361 -18
Miuna commented 2024-05-08 09:26:17 -04:00
Contributor
Copy Link

Title. Dot product was broken as it would normalize the vectors, giving incorrect values compared to conventional dot product calculations

Title. Dot product was broken as it would normalize the vectors, giving incorrect values compared to conventional dot product calculations
Miuna added 3 commits 2024-05-08 09:26:18 -04:00
Add AABBvAABB interesection & add AABB scale 82cb3d7ee3
Fix dot product ac4538bba5
Add triangle SAT intersection 4830015060
josh commented 2024-05-08 13:33:56 -04:00
Owner
Copy Link

Acceptable. Document that inputs to dot product are no longer normalized. So must now be normalized by the API consumer if they expect normalized outputs.

Acceptable. Document that inputs to dot product are no longer normalized. So must now be normalized by the API consumer if they expect normalized outputs.
josh merged commit 9114dd6886 into main 2024-05-08 13:35:05 -04:00
josh commented 2024-05-08 13:37:12 -04:00
Owner
Copy Link

Better yet, we can also implement DotNorm or something to that effect

Better yet, we can also implement DotNorm or something to that effect
josh commented 2024-05-08 13:38:56 -04:00
Owner
Copy Link

ALSO, A+ on starting to flesh out unit tests, i have continually avoided that...

ALSO, A+ on starting to flesh out unit tests, i have continually avoided that...
Miuna commented 2024-05-09 15:53:44 -04:00
Author
Contributor
Copy Link

Test Driven Development makes it easy 😄

[Test Driven Development](https://testdriven.io/test-driven-development/) makes it easy 😄
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
maxine josh
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: josh/j3ml#27
No description provided.
Delete Branch "Miuna/j3ml-fork:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?