josh/jlog
1
0
Fork 0
Code Issues 6 Pull Requests Packages Projects Releases 19 Wiki Activity

Does this difference in log function param matter between platforms? #5

New Issue
Closed
opened 2024-06-28 10:24:10 -04:00 by maxine · 3 comments
maxine commented 2024-06-28 10:24:10 -04:00
Collaborator
Copy Link

Linux
void log(std::vector<token> tokens)

Windows
void log(const std::vector<token> tokens)

Linux ```void log(std::vector<token> tokens) ``` Windows ```void log(const std::vector<token> tokens)```
josh commented 2024-06-28 11:17:33 -04:00
Owner
Copy Link

The platform-parity issue has been mostly "solved" by moving the bulk of the logic to shared/jlog.cpp, but it should probably be const std::vector& anyway unless it gets modified somehow.

The platform-parity issue has been mostly "solved" by moving the bulk of the logic to shared/jlog.cpp, but it should probably be const std::vector<token>& anyway unless it gets modified somehow.
maxine commented 2024-06-28 13:21:46 -04:00
Author
Collaborator
Copy Link

Got it. Should it be const std::vector& for only Windows or both of them? On Linux I had some issues with that trying to stop clangd's bitching.

Got it. Should it be ```const std::vector&``` for only Windows or both of them? On Linux I had some issues with that trying to stop clangd's bitching.
josh commented 2024-06-28 14:57:50 -04:00
Owner
Copy Link

The interface should be const type& if it is not a primitive type (numbers etc) and it will not be modified by the function. The implementation for both platforms should match the interfaces' function signatures. Can you elaborate on the clangd complaint?

The interface should be const type& if it is not a primitive type (numbers etc) and it will not be modified by the function. The implementation for both platforms should match the interfaces' function signatures. Can you elaborate on the clangd complaint?
josh closed this issue 2024-07-01 15:32:47 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
maxine josh
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: josh/jlog#5
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?