Ability to specify custom logfile globally and per-function #3

New Issue

If we want globally we basically already got that. I think the easiest and best approach would be to modify the jlog::log function to accept both the tokens and the log file name. Then we just write a wrapper for using the global log file. This way we can easily do a log file per function.

All we gotta do is use a base jlog::log function like this.

void baselog(std::vector<token> tokens, const std::string& filename);

And have the global one defined too which is just a wrapper for the first one.

void log(std::vector<token> tokens);

If we want globally we basically already got that. I think the easiest and best approach would be to modify the jlog::log function to accept both the tokens and the log file name. Then we just write a wrapper for using the global log file. This way we can easily do a log file per function. All we gotta do is use a base jlog::log function like this. ``` void baselog(std::vector<token> tokens, const std::string& filename); ``` And have the global one defined too which is just a wrapper for the first one. ``` void log(std::vector<token> tokens); ```

maxine commented

2024-06-28 11:04:17 -04:00

We can probably implement something like the ERROR macro this way.

#define ERROR(i)   if (jlog::loglevel >= jlog::severity::error) { jlog::baselog(jlog::error_detailed_format(i, FUNCTION, __FILE__, __LINE__), "errors.log"); }

We can probably implement something like the ERROR macro this way. ``` #define ERROR(i) if (jlog::loglevel >= jlog::severity::error) { jlog::baselog(jlog::error_detailed_format(i, FUNCTION, __FILE__, __LINE__), "errors.log"); } ```

josh commented

2024-06-28 11:12:55 -04:00

I've implemented log_to_file(filename, message) variant aswell as a set_default_logfile method. I consider this issue closed, but if you have any further input go for it.

maxine commented

2024-06-28 11:40:00 -04:00

Kinda got this working. The global logger is inside of the shared header. It's pretty generic afaik

maxine commented

2024-06-28 13:00:34 -04:00

I got this done even better. Way more flexible now and way easier to implement custom loggers.

3e414abc8d

I got this done even better. Way more flexible now and way easier to implement custom loggers. https://git.redacted.cc/josh/jlog/commit/3e414abc8d85a16ad379f81879d31c4a818579fa

maxine closed this issue

2024-06-28 13:00:34 -04:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Blocks

#4 Log results to test_results.txt.

josh/jtest

Reference: josh/jlog#3