josh/jlog
1
0
Fork 0
Code Issues 6 Pull Requests Packages Projects Releases 19 Wiki Activity

Mechanism to allow jlog to **not** log anything to console on release builds. #11

New Issue
Closed
opened 2024-07-02 12:19:58 -04:00 by josh · 3 comments
josh commented 2024-07-02 12:19:58 -04:00
Owner
Copy Link

Justification is that on Windows, any call to console log opens a CMD process if one is not already attached to the window. This is generally undesirable for release builds of game applications.

Enabled by default, but users of the library can toggle it easily.

Justification is that on Windows, any call to console log opens a CMD process if one is not **already** attached to the window. This is generally undesirable for release builds of game applications. Enabled by default, but users of the library can toggle it easily.
josh self-assigned this 2024-07-02 12:20:04 -04:00
maxine was assigned by josh 2024-07-02 12:20:04 -04:00
josh added the
Kind/Enhancement
Priority
Medium
 labels 2024-07-02 12:20:09 -04:00
maxine commented 2024-07-03 10:44:57 -04:00
Collaborator
Copy Link

We can probably use an ifdef where if a macro called DEBUG is set then log to both file and console otherwise log only to file

We can probably use an ifdef where if a macro called DEBUG is set then log to both file and console otherwise log only to file
maxine commented 2024-07-18 10:07:05 -04:00
Collaborator
Copy Link

I'm banging out some issues today. This is the first one.

I'm banging out some issues today. This is the first one.
maxine commented 2024-07-18 10:50:25 -04:00
Collaborator
Copy Link

Done. Just a simple macro and global variable.

f7ee1a347e

Done. Just a simple macro and global variable. https://git.redacted.cc/josh/jlog/commit/f7ee1a347e03ea6436dac7b2f216ac93d270d6ef
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Kind/Enhancement
Priority
Medium
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
maxine josh
No Assignees josh maxine
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: josh/jlog#11
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?