From 1a5737a356ca57e4a3ff65cc5d43ba8b49290d49 Mon Sep 17 00:00:00 2001
From: josh <josh@stepbro.wtf>
Date: Sun, 2 Feb 2025 22:09:43 -0500
Subject: [PATCH] Deprecate BitTwiddling module, fix obsolete standard header
 inclusion

---
 include/J3ML/J3ML.hpp |  2 +-
 src/J3ML/J3ML.cpp     | 23 +++--------------------
 2 files changed, 4 insertions(+), 21 deletions(-)

diff --git a/include/J3ML/J3ML.hpp b/include/J3ML/J3ML.hpp
index 10da82a..173ab14 100644
--- a/include/J3ML/J3ML.hpp
+++ b/include/J3ML/J3ML.hpp
@@ -165,7 +165,7 @@ namespace J3ML::BitTwiddling {
     u32 BinaryStringToValue(const char* s);
 
     /// Returns the number of 1's set in the given value.
-    inline int CountBitsSet(u32 value);
+    //inline int CountBitsSet(u32 value);
 }
 
 namespace J3ML::Math {
diff --git a/src/J3ML/J3ML.cpp b/src/J3ML/J3ML.cpp
index 7719134..2cd7130 100644
--- a/src/J3ML/J3ML.cpp
+++ b/src/J3ML/J3ML.cpp
@@ -10,8 +10,7 @@
 
 #include <format>
 #include <iomanip>
-#include <strstream>
-#include "J3ML/J3ML.hpp"
+#include <J3ML/J3ML.hpp>
 
 #include <sstream>
 
@@ -133,9 +132,7 @@ namespace J3ML::Math::Functions::Trigonometric {
 
 }
 
-namespace J3ML::Math::Functions {
-
-}
+namespace J3ML::Math::Functions { }
 
 namespace J3ML {
 
@@ -169,9 +166,6 @@ namespace J3ML {
         return 1.f / Sqrt(x);
     }
 
-
-
-
     int SigFigsTable[] = {0,0,0,1,0,0,1,0,0,1};
 
     int DivBy[] = {1,1,1, 1000,1000,1000, 1000000, 1000000, 1000000, 1000000000, 1000000000,1000000000};
@@ -297,8 +291,6 @@ namespace J3ML {
         return 1.f / x;
     }
 
-
-
     Math::Rotation::Rotation() : valueInRadians(0) {}
 
     Math::Rotation::Rotation(float value) : valueInRadians(value) {}
@@ -311,19 +303,10 @@ namespace J3ML {
         return {valueInRadians + rhs.valueInRadians};
     }
 
-
-
-    int BitTwiddling::CountBitsSet(u32 value) {
-
-    }
-
-
-
+    // int BitTwiddling::CountBitsSet(u32 value) { }
 
     namespace Math::Functions {
 
-
-
         bool IsPow2(u32 number) {
             return (number & (number - 1)) == 0;
         }