Today's build error is... #12
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
A fresh clone of the current code as of 20241214 gives lots of build errors due to things related to the Tile class. See attached text file for console log of failed build.
above now works, todays build error Core/src/Core/Generator.cpp :
/usr/include/c++/13/functional:847:21: error: static assertion failed: Wrong number of arguments for pointer-to-member
/home/rich/Redacted/ReCaveGame/Core/src/Core/Generator.cpp:183:17: error: ‘clay_pass’ was not declared in this scope
[ 67%] Building CXX object _deps/jgl-build/CMakeFiles/JGL_Demo.dir/main.cpp.o
In file included from /home/rich/Redacted/ReCaveGame/build/_deps/j3ml-src/include/J3ML/Geometry.hpp:15,
from /home/rich/Redacted/ReCaveGame/Core/include/Core/SimpleAABBSolver.hpp:15,
from /home/rich/Redacted/ReCaveGame/Core/src/Core/SimpleAABBSolver.cpp:1:
/home/rich/Redacted/ReCaveGame/build/_deps/j3ml-src/include/J3ML/Geometry/QuadTree.hpp: In member function ‘J3ML::Geometry::AABB2D J3ML::Geometry::QuadTree::Node::ComputeAABB()’:
/home/rich/Redacted/ReCaveGame/build/_deps/j3ml-src/include/J3ML/Geometry/QuadTree.hpp:55:35: warning: no return statement in function returning non-void [-Wreturn-type]
55 | AABB2D ComputeAABB() {}
| ^
In file included from /home/rich/Redacted/ReCaveGame/Core/include/Core/Chunk.hpp:14:
/home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp: In member function ‘virtual bool CaveGame::Core::Tile::SpreadCheck(CaveGame::Core::ITileMap*, CaveGame::Core::TileState, int, int, CaveGame::Core::TileID)’:
/home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp:146:102: warning: no return statement in function returning non-void [-Wreturn-type]
146 | virtual bool SpreadCheck(ITileMap* world, TileState state, int x, int y, TileID spreads_to) {}
| ^
In file included from /home/rich/Redacted/ReCaveGame/Core/include/Core/Registry.hpp:208,
from /home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp:7:
/usr/include/c++/13/functional: In instantiation of ‘struct std::_Bind_check_arity<float (CaveGame::Core::Generator::)(int, int, float, float, float, float), CaveGame::Core::Generator, int&, int&, const std::_Placeholder<4>&>’:
/usr/include/c++/13/functional:859:12: required from ‘struct std::_Bind_helper<false, float (CaveGame::Core::Generator::)(int, int, float, float, float, float), CaveGame::Core::Generator, int&, int&, const std::_Placeholder<4>&>’
/usr/include/c++/13/functional:881:5: required by substitution of ‘template<class _Func, class ... _BoundArgs> constexpr typename std::_Bind_helper<std::__is_socketlike<_Func>::value, _Func, _BoundArgs ...>::type std::bind(_Func&&, _BoundArgs&& ...) [with _Func = float (CaveGame::Core::Generator::)(int, int, float, float, float, float); _BoundArgs = {CaveGame::Core::Generator, int&, int&, const std::_Placeholder<4>&}]’
/home/rich/Redacted/ReCaveGame/Core/src/Core/Generator.cpp:123:42: required from here
/usr/include/c++/13/functional:847:21: error: static assertion failed: Wrong number of arguments for pointer-to-member
846 | static_assert(_Varargs::value
| ~~~~~
847 | ? sizeof...(_BoundArgs) >= _Arity::value + 1
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
848 | : sizeof...(_BoundArgs) == _Arity::value + 1,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/13/functional:847:21: note: ‘(false ? (4 >= (((long unsigned int)std::integral_constant<long unsigned int, 6>::value) + 1)) : (4 == (((long unsigned int)std::integral_constant<long unsigned int, 6>::value) + 1)))’ evaluates to false
/usr/include/c++/13/functional: In instantiation of ‘struct std::_Bind_check_arity<float (CaveGame::Core::Generator::)(int, int, float, float, float, float), CaveGame::Core::Generator, std::_Bind<float (CaveGame::Core::Generator::(CaveGame::Core::Generator, int, int, std::_Placeholder<4>))(int, int, float, float, float, float)>&, std::_Bind<float (CaveGame::Core::Generator::(CaveGame::Core::Generator, int, int, std::_Placeholder<4>))(int, int, float, float, float, float)>&, const std::_Placeholder<1>&>’:
/usr/include/c++/13/functional:859:12: required from ‘struct std::_Bind_helper<false, float (CaveGame::Core::Generator::)(int, int, float, float, float, float), CaveGame::Core::Generator, std::_Bind<float (CaveGame::Core::Generator::(CaveGame::Core::Generator, int, int, std::_Placeholder<4>))(int, int, float, float, float, float)>&, std::_Bind<float (CaveGame::Core::Generator::(CaveGame::Core::Generator, int, int, std::_Placeholder<4>))(int, int, float, float, float, float)>&, const std::_Placeholder<1>&>’
/usr/include/c++/13/functional:881:5: required by substitution of ‘template<class _Func, class ... _BoundArgs> constexpr typename std::_Bind_helper<std::__is_socketlike<_Func>::value, _Func, _BoundArgs ...>::type std::bind(_Func&&, _BoundArgs&& ...) [with _Func = float (CaveGame::Core::Generator::)(int, int, float, float, float, float); _BoundArgs = {CaveGame::Core::Generator, std::_Bind<float (CaveGame::Core::Generator::(CaveGame::Core::Generator, int, int, std::_Placeholder<4>))(int, int, float, float, float, float)>&, std::_Bind<float (CaveGame::Core::Generator::(CaveGame::Core::Generator, int, int, std::_Placeholder<4>))(int, int, float, float, float, float)>&, const std::_Placeholder<1>&}]’
/home/rich/Redacted/ReCaveGame/Core/src/Core/Generator.cpp:124:41: required from here
/usr/include/c++/13/functional:847:21: error: static assertion failed: Wrong number of arguments for pointer-to-member
/usr/include/c++/13/functional:847:21: note: ‘(false ? (4 >= (((long unsigned int)std::integral_constant<long unsigned int, 6>::value) + 1)) : (4 == (((long unsigned int)std::integral_constant<long unsigned int, 6>::value) + 1)))’ evaluates to false
/home/rich/Redacted/ReCaveGame/Core/src/Core/Generator.cpp: In member function ‘CaveGame::Core::TileID CaveGame::Core::Generator::ComputeTile(int, int)’:
/home/rich/Redacted/ReCaveGame/Core/src/Core/Generator.cpp:183:17: error: ‘clay_pass’ was not declared in this scope
183 | clay_pass, 0.85f, -0.75f, TileID::CLAY, TileID::DIRT,
| ^~~~~~~~~
In file included from /home/rich/Redacted/ReCaveGame/Core/src/Core/Tile.cpp:1:
/home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp: In member function ‘virtual bool CaveGame::Core::Tile::SpreadCheck(CaveGame::Core::ITileMap*, CaveGame::Core::TileState, int, int, CaveGame::Core::TileID)’:
/home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp:146:102: warning: no return statement in function returning non-void [-Wreturn-type]
146 | virtual bool SpreadCheck(ITileMap* world, TileState state, int x, int y, TileID spreads_to) {}
| ^
In file included from /home/rich/Redacted/ReCaveGame/Core/include/Core/Chunk.hpp:13,
from /home/rich/Redacted/ReCaveGame/Core/include/Core/World.hpp:2,
from /home/rich/Redacted/ReCaveGame/Core/src/Core/World.cpp:1:
/home/rich/Redacted/ReCaveGame/build/_deps/j3ml-src/include/J3ML/Geometry/QuadTree.hpp: In member function ‘J3ML::Geometry::AABB2D J3ML::Geometry::QuadTree::Node::ComputeAABB()’:
/home/rich/Redacted/ReCaveGame/build/_deps/j3ml-src/include/J3ML/Geometry/QuadTree.hpp:55:35: warning: no return statement in function returning non-void [-Wreturn-type]
55 | AABB2D ComputeAABB() {}
| ^
[ 68%] Building CXX object _deps/jui-build/CMakeFiles/JUI.dir/src/JUI/Base/LayoutContainer.cpp.o
make[2]: *** [Core/CMakeFiles/CaveCore.dir/build.make:132: Core/CMakeFiles/CaveCore.dir/src/Core/Generator.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
above corrected. current build error is line 141 of Client/src/Client/LocalWorld.cpp which seems to be an incomplete if() statement.
If I delete line 141 it builds and runs fine.
Lots of build errors relating to tilesto Today's build error is...Today's build error: ‘SLUSH’ is not a member of ‘CaveGame::Core::Tiles::ID’ {aka ‘CaveGame::Core::TileID’}
[ 82%] Building CXX object Core/CMakeFiles/CaveCore.dir/src/Core/Chunk.cpp.o
In file included from /home/rich/Redacted/ReCaveGame/Core/include/Core/Chunk.hpp:13,
from /home/rich/Redacted/ReCaveGame/Core/src/Core/Chunk.cpp:1:
/home/rich/Redacted/ReCaveGame/build/_deps/j3ml-src/include/J3ML/Geometry/QuadTree.hpp: In member function ‘J3ML::Geometry::AABB2D J3ML::Geometry::QuadTree::Node::ComputeAABB()’:
/home/rich/Redacted/ReCaveGame/build/_deps/j3ml-src/include/J3ML/Geometry/QuadTree.hpp:55:35: warning: no return statement in function returning non-void [-Wreturn-type]
55 | AABB2D ComputeAABB() {}
| ^
In file included from /home/rich/Redacted/ReCaveGame/Core/include/Core/Chunk.hpp:14:
/home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp: In member function ‘virtual bool CaveGame::Core::Tile::SpreadCheck(CaveGame::Core::ITileMap*, CaveGame::Core::TileState, int, int, CaveGame::Core::TileID)’:
/home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp:146:102: warning: no return statement in function returning non-void [-Wreturn-type]
146 | virtual bool SpreadCheck(ITileMap* world, TileState state, int x, int y, TileID spreads_to) {}
| ^
/home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp: At global scope:
/home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp:263:38: error: ‘SLUSH’ is not a member of ‘CaveGame::Core::Tiles::ID’ {aka ‘CaveGame::Core::TileID’}
263 | static const Tile Slush {ID::SLUSH, "Slush", Colors::Blues::LightBlue};
| ^~~~~
/home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp:263:78: error: no matching function for call to ‘CaveGame::Core::Tile::Tile()’
263 | static const Tile Slush {ID::SLUSH, "Slush", Colors::Blues::LightBlue};
| ^
/home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp:135:9: note: candidate: ‘CaveGame::Core::Tile::Tile(CaveGame::Core::TileID, const std::string&, const Color4&, const std::vector&)’
135 | Tile(TileID id, const std::string& name, const Color4& color, const std::vector& pallet);
| ^~~~
/home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp:135:9: note: candidate expects 4 arguments, 3 provided
/home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp:134:9: note: candidate: ‘CaveGame::Core::Tile::Tile(CaveGame::Core::TileID, const std::string&, const Color4&)’
134 | Tile(TileID id, const std::string& name, const Color4& color);
| ^~~~
/home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp:134:9: note: conversion of argument 1 would be ill-formed:
/home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp:133:9: note: candidate: ‘CaveGame::Core::Tile::Tile()’
133 | Tile();
| ^~~~
/home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp:133:9: note: candidate expects 0 arguments, 3 provided
/home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp:120:11: note: candidate: ‘constexpr CaveGame::Core::Tile::Tile(const CaveGame::Core::Tile&)’
120 | class Tile
| ^~~~
/home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp:120:11: note: candidate expects 1 argument, 3 provided
/home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp:120:11: note: candidate: ‘constexpr CaveGame::Core::Tile::Tile(CaveGame::Core::Tile&&)’
/home/rich/Redacted/ReCaveGame/Core/include/Core/Tile.hpp:120:11: note: candidate expects 1 argument, 3 provided
make[2]: *** [Core/CMakeFiles/CaveCore.dir/build.make:90: Core/CMakeFiles/CaveCore.dir/src/Core/Chunk.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1039: Core/CMakeFiles/CaveCore.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
Today's build error:
[ 38%] Building CXX object _deps/j3ml-build/tests/CMakeFiles/J3MLTestSuite.dir/tests.cpp.o
In file included from /home/rich/Redacted/ReCaveGame/build/_deps/j3ml-src/tests/tests.cpp:21:
/home/rich/Redacted/ReCaveGame/build/_deps/j3ml-src/tests/LinearAlgebra/Matrix3x3Tests.hpp: In lambda function:
/home/rich/Redacted/ReCaveGame/build/_deps/j3ml-src/tests/LinearAlgebra/Matrix3x3Tests.hpp:17:40: error: no matching function for call to ‘J3ML::LinearAlgebra::Matrix3x3::Matrix3x3(J3ML::LinearAlgebra::EulerAngleXYZ&)’
17 | Matrix3x3 m(expected_result);
| ^
/home/rich/Redacted/ReCaveGame/build/_deps/j3ml-src/tests/LinearAlgebra/Matrix3x3Tests.hpp:37:35: error: no matching function for call to ‘J3ML::LinearAlgebra::Matrix3x3::Matrix3x3(J3ML::LinearAlgebra::EulerAngleXYZ&)’
37 | Matrix3x3 from_euler(e);
|
Still cant build. This is the output of errors from a clean git clone of ReCaveGame (ubuntu 24.10 gcc 14.2):
Update: If once I get the above error I then cd to ReCaveGame/build/ClientApp/ and type make there, the CaveClientApp will build (and does run ok). But typing make in ReCaveGame/build/ still gives the error above.
I assigned all 3 of us to this, so we can keep track of it better. A lot of this looks to be J3ML and Cave Game Core related, so Josh will be better at debugging that than I am. Bill should be able to provide some help as well. I'm pretty much just here as emotional support until I figure out how all the code works for Cave Game since I was absent when Josh wrote it.
I'm aware of this, It's a thing that was changed slightly in J3ML but wasn't updated in the tests. I've just been ignoring it because I'm lazy and it builds anyways. I'll fix it in a little.
I can confirm this is now fixed.